Re: [PATCH V2] Thermal: imx: add i.mx6sx thermal support

[edubezval@xxxxxxxxx]

Hello again,

On Wed, Aug 6, 2014 at 8:56 AM, edubezval@xxxxxxxxx <edubezval@xxxxxxxxx> wrote:
> Hello Anson,
>
> On Wed, Aug 6, 2014 at 3:05 AM, Anson.Huang@xxxxxxxxxxxxx
> <Anson.Huang@xxxxxxxxxxxxx> wrote:
>> Sorry for leaving such warnings, I thought we did NOT care about the long
>> line issue now, will fix them in V3 patch.
>>
>
> Lines over 80 columns are not an error of style. We simply suggest to
> keep this. By now, I think it really depends on which subsystem you
> are working with. I would prefer you keep this rule, as most of the
> code inside the thermal framework follows it.
>

Let me put this straight, quoting the Kernel Documentation/CodingStyle:

 75                 Chapter 2: Breaking long lines and strings

 76

 77 Coding style is all about readability and maintainability using commonly

 78 available tools.

 79

 80 The limit on the length of lines is 80 columns and this is a strongly

 81 preferred limit.

 82

 83 Statements longer than 80 columns will be broken into sensible
chunks, unless

 84 exceeding 80 columns significantly increases readability and does not hide

 85 information. Descendants are always substantially shorter than the
parent and

 86 are placed substantially to the right. The same applies to function headers

 87 with a long argument list. However, never break user-visible strings such as

 88 printk messages, because that breaks the ability to grep for them."







>>
>>
>> Thanks Varka.
>>
>>
>>
>> Best regards!
>>
>> Anson Huang
>>
>>
>>
>> From: Varka Bhadram [mailto:varkabhadram@xxxxxxxxx]
>> Sent: 2014-08-06 3:01 PM
>> To: Huang Yongcai-B20788; edubezval@xxxxxxxxx; shawn.guo@xxxxxxxxxx;
>> rui.zhang@xxxxxxxxx
>> Cc: linux-pm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>> devicetree@xxxxxxxxxxxxxxx
>> Subject: Re: [PATCH V2] Thermal: imx: add i.mx6sx thermal support
>>
>>
>>
>> On 08/06/2014 10:47 AM, Anson Huang wrote:
>>
>> i.MX6SX has some new features of thermal interrupt function,
>>
>> there are LOW, HIGH and PANIC irq for thermal sensor, so add
>>
>> platform data to separate different thermal version;
>>
>>
>>
>> The reset value of LOW ALARM is 0 which means the highest
>>
>> temp, so the LOW ALARM will be triggered once irq is enabled,
>>
>> so we need to correct it before enabling thermal irq;
>>
>>
>>
>> Enable PANIC ALARM as critical trip point, it will trigger
>>
>> system reset via SRC module once PANIC IRQ is triggered, it
>>
>> is pure hardware function, so use it instead of software
>>
>> reset by cooling device.
>>
>>
>>
>> Signed-off-by: Anson Huang <b20788@xxxxxxxxxxxxx>
>>
>> ---
>>
>>  .../devicetree/bindings/thermal/imx-thermal.txt    |    5 +-
>>
>>  drivers/thermal/imx_thermal.c                      |   89
>> +++++++++++++++++---
>>
>>  2 files changed, 80 insertions(+), 14 deletions(-)
>>
>>
>>
>> ./scripts/checkpatch.pl --show-types
>> V2-Thermal-imx-add-i.mx6sx-thermal-support.patch
>>
>> WARNING:LONG_LINE: line over 80 characters
>>
>> #109: FILE: drivers/thermal/imx_thermal.c:185:
>>
>> +    /* Update alarm value to next higher trip point, only TEMPMON_IMX6Q
>> needs it */
>>
>>
>>
>> WARNING:LONG_LINE: line over 80 characters
>>
>> #111: FILE: drivers/thermal/imx_thermal.c:187:
>>
>> +        if (data->alarm_temp == data->temp_passive && *temp >=
>> data->temp_passive)
>>
>>
>>
>> WARNING:LONG_LINE: line over 80 characters
>>
>> #113: FILE: drivers/thermal/imx_thermal.c:189:
>>
>> +        if (data->alarm_temp == data->temp_critical && *temp <
>> data->temp_passive) {
>>
>>
>>
>> --
>>
>> Regards,
>>
>> Varka Bhadram.
>
>
>
> --
> Eduardo Bezerra Valentin



-- 
Eduardo Bezerra Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/