Re: [PATCH] alarmtimer: Add the verification code for rtc device error.

From: Hyogi Gim
Date: Wed Aug 06 2014 - 22:00:40 EST




On 07/31/2014 02:58 AM, John Stultz wrote:
>
> Hey! Sorry for the late response here.
>
> So this seems reasonable as always failing suspend is problematic, but
> I worry that for the case where we do have a failure to read or set
> the RTC, we'd suspend and not wake up as specified, which is an issue
> as well. Absorbing the error silently in these cases would make it
> difficult to debug. Should we at least print some output out to help
> folks hunt down this sort of issue?
>

I agree. Most RTC device drivers don't print out the error of read_time.
So, I think the higher level like /drivers/rtc/interface.c should check
the error and give the information of the RTC device status.

I'll try to find a proper point.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/