Re: linux-next: Tree for Aug 6 (sun6i-dma.c)

[Philipp Zabel]

Am Mittwoch, den 06.08.2014, 10:15 -0700 schrieb Randy Dunlap:
> On 08/06/14 09:42, Randy Dunlap wrote:
> > On 08/06/14 00:28, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Please do not add code intended for v3.18 until after v3.17-rc1 is
> >> released.
> >>
> >> Changes since 20140805:
> >>
> > 
> > on x86_64:
> > when CONFIG_RESET_CONTROLLER is not enabled:
> > 
> > ../drivers/dma/sun6i-dma.c: In function 'sun6i_dma_probe':
> > ../drivers/dma/sun6i-dma.c:911:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
> > 
> > Add a stub for that function?

There is no stub for this function by choice.
Drivers that can accept stubbed out CONFIG_RESET_CONTROLLER functions
should use devm_reset_control_get_optional instead.

> or that driver's Kconfig entry could select RESET_CONTROLLER.

Yes, please.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/