Re: [PATCH 5/5] Export the temperatures via hwmon

[Jean Delvare]

Le Thursday 07 August 2014 Ã 00:36 -0700, Guenter Roeck a Ãcrit :
> On 08/06/2014 11:52 PM, Jean Delvare wrote:
> > Hi Guenter,
> >
> > On Wed, 06 Aug 2014 23:20:32 -0700, Guenter Roeck wrote:
> >> Patch 4/5 is "Return the fan speed via sysfs: /sys/devices/temperature/fan_level".
> >>
> >> So you are saying that returning the fan speed with a non-hwmon attribute works,
> >> but returning it with a hwmon attribute doesn't ? Not really sure if I understand
> >> your logic. Either fan_level doesn't return the fan speed (or an abstraction of it),
> >> or something in your line of argument is inconsistent.
> >
> > fan_level is a fan speed _control_ value, like pwm1. It is not a fan
> > speed monitoring value.
> >
> Ah, ok. The patch description doesn't seem to match, though.
> And why not export it as pwm1, if that is what it is ?

Well, /sys/devices/temperature is a non-standard interface anyway, so it
does not really matter. I already discussed with Goffredo the
possibility to also expose it as pwm1 on the hwmon side, this might
happen later.

-- 
Jean Delvare
SUSE L3 Support

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/