Re: linux-next: Tree for Aug 6 (sun6i-dma.c)

[Vinod Koul]

On Thu, Aug 07, 2014 at 01:25:07PM +0200, Maxime Ripard wrote:
> On Thu, Aug 07, 2014 at 09:56:14AM +0200, Philipp Zabel wrote:
> > Am Mittwoch, den 06.08.2014, 10:15 -0700 schrieb Randy Dunlap:
> > > On 08/06/14 09:42, Randy Dunlap wrote:
> > > > On 08/06/14 00:28, Stephen Rothwell wrote:
> > > >> Hi all,
> > > >>
> > > >> Please do not add code intended for v3.18 until after v3.17-rc1 is
> > > >> released.
> > > >>
> > > >> Changes since 20140805:
> > > >>
> > > > 
> > > > on x86_64:
> > > > when CONFIG_RESET_CONTROLLER is not enabled:
> > > > 
> > > > ../drivers/dma/sun6i-dma.c: In function 'sun6i_dma_probe':
> > > > ../drivers/dma/sun6i-dma.c:911:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
> > > > 
> > > > Add a stub for that function?
> > 
> > There is no stub for this function by choice.
> > Drivers that can accept stubbed out CONFIG_RESET_CONTROLLER functions
> > should use devm_reset_control_get_optional instead.
> > 
> > > or that driver's Kconfig entry could select RESET_CONTROLLER.
> > 
> > Yes, please.
> 
> A depends on would be better I guess.
Patch pls :)

-- 
~Vinod

Attachment: signature.asc
Description: Digital signature