Re: [PATCH] 6lowpan: Allow 6LoWPAN to be modular

From: Geert Uytterhoeven
Date: Thu Aug 07 2014 - 12:44:42 EST


Hi Marcel,

On Thu, Aug 7, 2014 at 6:00 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>> Change config symbol 6LOWPAN from type bool to type tristate, so
>> 6LoWPAN can be built modular, just like IPV6
>>
>> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> ---
>> net/6lowpan/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/6lowpan/Kconfig b/net/6lowpan/Kconfig
>> index 028a5c6d1f61..e4a02ef55102 100644
>> --- a/net/6lowpan/Kconfig
>> +++ b/net/6lowpan/Kconfig
>> @@ -1,5 +1,5 @@
>> config 6LOWPAN
>> - bool "6LoWPAN Support"
>> + tristate "6LoWPAN Support"
>
> is this a regression from the previous CONFIG_6LOWPAN separation that we introduced? If it is, then it might be easiest if Dave just takes it into his net tree. Otherwise I take it through bluetooth-next.

I hadn't thought about that... Checking...

Yes, I believe this is a regression.

In v3.16, my allmodconfig build had:

CONFIG_IEEE802154_6LOWPAN=m
CONFIG_6LOWPAN_IPHC=m
CONFIG_BT_6LOWPAN=y

Without my patch it has:

CONFIG_6LOWPAN=y
CONFIG_IEEE802154_6LOWPAN=m
CONFIG_BT_6LOWPAN=m

and iphc is what's in net/6lowpan/built-in.o now.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/