Re: [RFC 4/5] ARM: dts: add pinctrl support to Exynos5410

[Tomasz Figa]

Hi,

Please see my comment inline.

On 28.07.2014 14:18, Andreas Färber wrote:
> From: Hakjoo Kim <ruppi.kim@xxxxxxxxxxxxxx>
> 
> Add the required pin configuration support to Exynos5410 using pinctrl
> interface.

[snip]

> +	pinctrl_0: pinctrl@13400000 {
> +		compatible = "samsung,exynos5410-pinctrl";
> +		reg = <0x13400000 0x1000>;
> +		interrupts = <0 45 0>;

I believe you are missing the wake-up IRQ controller node here, which is
needed to handle the interrupts of EINTW (gpxN) banks.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/