Re: [PATCH 07/10 v3] coresight-etm: add CoreSight ETM/PTM driver

[Mathieu Poirier]

On 7 August 2014 23:28, Dirk Behme <dirk.behme@xxxxxxxxxxxx> wrote:
> On 07.08.2014 20:21, mathieu.poirier@xxxxxxxxxx wrote:
>>
>> From: Pratik Patel <pratikp@xxxxxxxxxxxxxx>
>>
>> This driver manages CoreSight ETM (Embedded Trace Macrocell) that
>> supports processor tracing. Currently supported version are ARM
>> ETMv3.x and PTM1.x.
>>
>> Signed-off-by: Pratik Patel <pratikp@xxxxxxxxxxxxxx>
>> Signed-off-by: Panchaxari Prasannamurthy
>> <panchaxari.prasannamurthy@xxxxxxxxxx>
>> Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
>> ---
>
> ...
>>
>> +static struct amba_id etm_ids[] = {
>> +       {       /* ETM 3.3 */
>> +               .id     = 0x0003b921,
>> +               .mask   = 0x0003ffff,
>> +       },
>> +       {       /* ETM 3.5 */
>> +               .id     = 0x0003b956,
>> +               .mask   = 0x0003ffff,
>> +       },
>> +       {       /* PTM */
>> +               .id     = 0x0003b95f,
>> +               .mask   = 0x0003ffff,
>> +       },
>> +       { 0, 0},
>
>
> Maybe you like to add PTM 1.0 [1] here, too?

You got it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/