Re: [PATCH v2 2/4] arm: mediatek: Add support for GIC interrupt polarity extension.

[Matthias Brugger]

2014-08-08 15:43 GMT+02:00 Joe.C <srv_yingjoe.chen@xxxxxxxxxxxx>:
> From: "Joe.C" <yingjoe.chen@xxxxxxxxxxxx>
>
> Mediatek SoCs have an interrupt polarity extension which allows
> to swap the polarity for given interrupts.

Please use ./script/checkpatch.pl, all 4 patches have errors.
Apart please use the get_maintainer.pl on all patches of a set and
send the whole set to all email addresses returned by the script.
Otherwise it will be really difficult to understand the context of the
patch set.

Cheers,
Matthias

>
> Signed-off-by: Joe.C <yingjoe.chen@xxxxxxxxxxxx>
> ---
>  arch/arm/mach-mediatek/Makefile   |  2 +-
>  arch/arm/mach-mediatek/common.h   | 19 ++++++++++++
>  arch/arm/mach-mediatek/intpol.c   | 61 +++++++++++++++++++++++++++++++++++++++
>  arch/arm/mach-mediatek/mediatek.c | 10 +++++++
>  4 files changed, 91 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/mach-mediatek/common.h
>  create mode 100644 arch/arm/mach-mediatek/intpol.c
>
> diff --git a/arch/arm/mach-mediatek/Makefile b/arch/arm/mach-mediatek/Makefile
> index 43e619f..82c39d8 100644
> --- a/arch/arm/mach-mediatek/Makefile
> +++ b/arch/arm/mach-mediatek/Makefile
> @@ -1 +1 @@
> -obj-$(CONFIG_ARCH_MEDIATEK) += mediatek.o
> +obj-$(CONFIG_ARCH_MEDIATEK) += mediatek.o intpol.o
> diff --git a/arch/arm/mach-mediatek/common.h b/arch/arm/mach-mediatek/common.h
> new file mode 100644
> index 0000000..8f2bbeb
> --- /dev/null
> +++ b/arch/arm/mach-mediatek/common.h
> @@ -0,0 +1,19 @@
> +/*
> + * Copyright (c) 2014 Mediatek Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +#ifndef __MEDIATEK_COMMON_H__
> +#define __MEDIATEK_COMMON_H__
> +
> +extern char init_intpol(void);
> +
> +#endif /* __MEDIATEK_COMMON_H__ */
> diff --git a/arch/arm/mach-mediatek/intpol.c b/arch/arm/mach-mediatek/intpol.c
> new file mode 100644
> index 0000000..65ccc7c
> --- /dev/null
> +++ b/arch/arm/mach-mediatek/intpol.c
> @@ -0,0 +1,61 @@
> +/*
> + * This file contains common code that is intended to be used across
> + * boards so that it's not replicated.
> + *
> + * Copyright (C) 2014 Mediatek Inc.
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +#include <linux/of_address.h>
> +#include <linux/io.h>
> +#include <linux/irq.h>
> +#include <linux/irqchip/arm-gic.h>
> +
> +#define GIC_HW_IRQ_BASE  32
> +#define INT_POL_INDEX(a)   ((a) - GIC_HW_IRQ_BASE)
> +
> +static void __iomem *int_pol_base;
> +
> +static int mtk_int_pol_set_type(struct irq_data *d, unsigned int type)
> +{
> +       unsigned int irq = d->hwirq;
> +       u32 offset, reg_index, value;
> +
> +       offset = INT_POL_INDEX(irq) & 0x1F;
> +       reg_index = INT_POL_INDEX(irq) >> 5;
> +
> +       /* This arch extension was called with irq_controller_lock held,
> +          so the read-modify-write will be atomic */
> +       value = readl(int_pol_base + reg_index * 4);
> +       if (type == IRQ_TYPE_LEVEL_LOW || type == IRQ_TYPE_EDGE_FALLING)
> +               value |= (1 << offset);
> +       else
> +               value &= ~(1 << offset);
> +       writel(value, int_pol_base + reg_index * 4);
> +
> +       return 0;
> +}
> +
> +void init_intpol(void)
> +{
> +       struct device_node *node;
> +
> +       node = of_find_compatible_node(NULL, NULL, "mediatek,mt6577-intpol");
> +       if (!node)
> +               return;
> +
> +       int_pol_base = of_io_request_and_map(node, 0, "intpol");
> +       if (IS_ERR(int_pol_base)) {
> +               pr_warn("Can't get resource\n");
> +               return;
> +       }
> +
> +       gic_arch_extn.irq_set_type = mtk_int_pol_set_type;
> +}
> diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/mach-mediatek/mediatek.c
> index 48051a2..aa10c70 100644
> --- a/arch/arm/mach-mediatek/mediatek.c
> +++ b/arch/arm/mach-mediatek/mediatek.c
> @@ -16,6 +16,15 @@
>   */
>  #include <linux/init.h>
>  #include <asm/mach/arch.h>
> +#include <linux/irqchip.h>
> +
> +#include "common.h"
> +
> +static void __init mediatek_init_irq(void)
> +{
> +       init_intpol();
> +       irqchip_init();
> +}
>
>  static const char * const mediatek_board_dt_compat[] = {
>         "mediatek,mt6589",
> @@ -26,4 +35,5 @@ static const char * const mediatek_board_dt_compat[] = {
>
>  DT_MACHINE_START(MEDIATEK_DT, "Mediatek Cortex-A7 (Device Tree)")
>         .dt_compat      = mediatek_board_dt_compat,
> +       .init_irq       = mediatek_init_irq,
>  MACHINE_END
> --
> 1.8.1.1.dirty
>



-- 
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/