Re: [PATCH] misc: ti-st: st_kim.c: Cleaning up missing null-terminate after strncpy call

[Mark D Rustad]

On Aug 9, 2014, at 4:45 PM, Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote:

> Added a guaranteed null-terminate after call to strncpy.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/misc/ti-st/st_kim.c |    1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c
> index 9d3dbb2..bce4468 100644
> --- a/drivers/misc/ti-st/st_kim.c
> +++ b/drivers/misc/ti-st/st_kim.c
> @@ -593,6 +593,7 @@ static ssize_t store_dev_name(struct device *dev,
> 	struct kim_data_s *kim_data = dev_get_drvdata(dev);
> 	pr_debug("storing dev name >%s<", buf);
> 	strncpy(kim_data->dev_name, buf, count);
> +	kim_data->dev_name[count - 1] = '\n';

Of course this does not add termination, but adds a newline at the end of the buffer? Huh?

> 	pr_debug("stored dev name >%s<", kim_data->dev_name);
> 	return count;
> }

-- 
Mark Rustad, MRustad@xxxxxxxxx

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail