Re: [alsa-devel] [PATCH 2/2] mfd: arizona: Update DT binding to support INn_MODE

[Mark Rutland]

On Sat, Aug 09, 2014 at 09:35:45AM +0100, Inha Song wrote:
> This patch update DT binding to support INn_MODE init_data
> 
> Signed-off-by: Inha Song <ideal.song@xxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/mfd/arizona.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 5c7e723..c21a30e 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -42,6 +42,11 @@ Optional properties:
>      the chip default will be used.  If present exactly five values must
>      be specified.
>  
> +  - wlf,inmode : A list of INn_MODE register values. If absent, INn_MODE register
> +    set to 0 by default. The size of this list depends on ARIZONA_MAX_INPUT values.
> +    ARIZONA_MAX_INPUT is defined in include/linux/mfd/arizona/pdata.h. If present,
> +    exactly ARIZONA_MAX_INPUT values must be specified.

Please don't refer to Linux internals here. How many INn_MODE registers
can this hardware have?

Why does this need to be overriden? Please mention this in the commit
message and documentation.

Why is exposing a raw register value the best way of doing this?

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/