Re: [PATCH 2/8] perf tools: Make __hpp__fmt() receive an additional len argument

[Arnaldo Carvalho de Melo]

Em Mon, Aug 11, 2014 at 05:05:33PM +0900, Namhyung Kim escreveu:
> Hi Arnaldo,
> 
> On Sat, 2 Aug 2014 10:30:26 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jul 31, 2014 at 02:47:36PM +0900, Namhyung Kim escreveu:
> >> So that it can properly handle alignment requirements later.  To do
> >> that, add percent_color_len_snprintf() fucntion to help coloring of
> >> overhead columns.
> >
> > Can you elaborate on this description? What is not possible to do before
> > this patch?
> 
> This patch is a preparation that moves hard-coded print width out of the
> format string so that it can be passed from external settings later.

Ok, please add this to the patch description?
 
> > Perhaps a formatted line before this patch and then the same line
> > formatted after the patch?
 
> The default behavior wasn't changed, it's only meaningful when user
> gives field width using -w option.  You can see the difference in the
> description 0/8.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/