Re: [PATCH v2 linux-next] arch/x86/mm: sparse 'tlb_single_page_flush_ceiling' warning

[Dave Hansen]

On 08/09/2014 12:38 AM, Jeremiah Mahler wrote:
> A sparse warning is generated about 'tlb_single_page_flush_ceiling'
> not being declared.
> 
>   arch/x86/mm/tlb.c:177:15: warning: symbol
>   'tlb_single_page_flush_ceiling' was not declared. Should it be static?
> 
> Since it isn't used anywhere outside this file, fix the warning by
> making it static.
> 
> Also, optimize the use of this variable by adding the __read_mostly
> directive.

Looks fine to me.  It's definitely __read_mostly.

Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/