Re: [PATCH] drm: Do not use BUG_ON(!spin_is_locked())

From: David Rientjes
Date: Mon Aug 11 2014 - 16:53:55 EST


On Mon, 11 Aug 2014, sanjeev sharma wrote:

> Hello David,
>
> Here is the old discussion carried out on this.
>
> http://linux-kernel.2935.n7.nabble.com/Is-spin-is-locked-safe-to-use-with-BUG-ON-WARN-ON-td654800.html#a921802
>

I'm suggesting that if you don't want to incur the cost of the conditional
everytime you call a certain function with assert_spin_locked() that you
could covert these to lockdep_assert_held() so the check is only done when
lockdep is enabled for debugging.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/