Re: [PATCH] Made bpf_internal_load_pointer_neg_helper static: fixes Sparse warning

[Daniel Borkmann]

On 08/12/2014 02:57 AM, Alexei Starovoitov wrote:
> On Mon, Aug 11, 2014 at 3:00 PM, Benjamin Lee <leeben@xxxxxxxxxxxxxxxxxx> wrote:
> > I wanted to know what the current status of my patch is since my
> > internship will be ending this Friday and I want to know before then. if
> > there are any problems with it I can fix them before Thursday. Thank you
> > in advance.
>
> using scripts/get_maintainer.pl for cc list would have helped to
> receive response sooner.
>
> > On Fri, 2014-07-18 at 11:34 -0700, Benjamin Lee wrote:
> > > This patch fixes the following Sparse warning:
> > >
> > > net/core/filter.c:52:6: warning: symbol
> > > 'bpf_internal_load_pointer_neg_helper' was not declared. Should it be
> > > static?
> > >
> > > I declared bpf_internal_load_pointer_neg_helper as static because it
> > > is not referenced elsewhere in the kernel. The patched kernel boots
>
> the patch is incorrect, since this function is called out of assembler.
> Try 'git grep bpf_internal_load_pointer_neg_helper'

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/