Re: [PATCH RFC 0/4] VFS revoke()

[Al Viro]

On Tue, Aug 12, 2014 at 08:54:04PM +0200, David Herrmann wrote:

> Open questions:
>  * Obviously, we need to protect all calls into file->f_op->xyz(). This series
>    provides enter_file() and leave_file() that can be used like:
>       if (enter_file(file))
>           retval = file->f_op->xyz(file, ...);
>       else
>           retval = -ENODEV;
>    Question is, should we do this at the time we actually invoke those
>    callbacks or should we do it at the syscall-entry time?

The former, obviously.  The real bitch is around mmap - you don't need
that for evdev, but generic solution would better deal with that kind
of crap.

I'll post a review once I'm done with Eric's patchset; hopefully tonight or
tomorrow morning.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/