Re: [RFC PATCH 01/10] scsi/constants: Cleanup printk message in __scsi_print_sense()

[Yoshihiro YUNOMAE]

Hi Elliot,

Thank you for your comment.

(2014/08/12 23:51), Elliott, Robert (Server Storage) wrote:
> > -----Original Message-----
> > From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi-
> > owner@xxxxxxxxxxxxxxx] On Behalf Of Yoshihiro YUNOMAE
> > Sent: Friday, 08 August, 2014 6:50 AM
> ...
> > Subject: [RFC PATCH 01/10] scsi/constants: Cleanup printk message in
> > __scsi_print_sense()
> >
> > A device name is output like "sda: Sense Key : Medium Error [current]"
> > in __scsi_print_sense(), but it should be "[sda] Sense Key : Medium Error
> > [current]" because other printk messages output a device name like "[sda]
> > foo."
> ...
> > diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c
> > index c6a7a4a..a0e8159 100644
> > --- a/drivers/scsi/constants.c
> > +++ b/drivers/scsi/constants.c
> > @@ -1470,7 +1470,7 @@ void __scsi_print_sense(struct scsi_device *sdev,
> > const char *name,
> >   		return;
> >   	}
> >
> > -	sdev_printk(KERN_INFO, sdev, "%s: Sense Key : %s %s%s\n", name,
> > +	sdev_printk(KERN_INFO, sdev, "[%s] Sense Key : %s %s%s\n", name,
> >   	       scsi_sense_key_string(sshdr.sense_key),
> >   	       scsi_sense_type_string(&sshdr),
> >   	       scsi_sense_format_string(&sshdr));
>
>
> The callers of __scsi_print_sense do not always pass in a name
> like "sda".  In fact, sd.c doesn't even call that function; its
> sd_print_sense_hdr calls sd_printk (which prints name as "[%s]")
> and scsi_show_sense_hdr.

OK, I understood.
Current Linux kernel also outputs "<name>:" in __scsi_print_sense(),
so we should not change this.

Thanks,
Yoshihiro YUNOMOAE

--
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/