Re: [PATCH] mmc: dw_mmc: Remove architecture dependency

[Andrew Bresticker]

> In general, it's best to have specific dependencies on the subsystem
> a driver uses. You probably need something like
>
>         depends on HAS_IOMEM && COMMON_CLK && REGULATOR
>         depends on COMPILE_TEST || ARC || ARM || MIPS
>
> to cover all the possible cases. The specific options are probably
> not the ones I listed above, but you should get the idea. Most importantly,
> you don't want to allow building the driver on architectures on which
> it can't compile.

The only compile-time dependencies I see are HAS_IOMEM (which MMC
already depends on) and HAS_DMA.  There isn't any compile-time
dependency on COMMON_CLK, REGULATOR, GPIOLIB, OF, etc.  I've compiled
it successfully for a few non-ARM/ARC architectures, though that
certainly isn't an exhaustive test.  To be safe though, perhaps I'll
just update the architecture dependency to include MIPS ||
COMPILE_TEST as you suggested.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/