Re: [PATCH v2] firmware: Do not use WARN_ON(!spin_is_locked())

[Matt Fleming]

On Wed, 13 Aug, at 11:21:34AM, Guenter Roeck wrote:
> spin_is_locked() always returns false for uniprocessor configurations
> in several architectures, so do not use WARN_ON with it.
> Use lockdep_assert_held() instead to also reduce overhead in
> non-debug kernels.
> 
> Cc: Matt Fleming <matt.fleming@xxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> v2: Use lockdep_assert_held instead of WARN_ON_SMP.
> 
>  drivers/firmware/efi/vars.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Thanks Guenter, applied!

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/