Re: [PATCH v2] cpuidle/cpuidle-big_little: fix reading cpu id part number

From: Juri Lelli
Date: Fri Aug 15 2014 - 12:36:05 EST


On 15/08/14 17:32, Kevin Hilman wrote:
> Juri Lelli <juri.lelli@xxxxxxx> writes:
>
>> Commit af040ffc9ba1 ("ARM: make it easier to check the CPU part number
>> correctly") changed ARM_CPU_PART_X masks, and the way they are returned and
>> checked against. Usage of read_cpuid_part_number() is now deprecated, and
>> calling places updated accordingly. This actually broke cpuidle-big_little
>> initialization, as bl_idle_driver_init() performs a check using an hardcoded
>> mask on cpu_id.
>>
>> Create an interface to perform the check (that is now even easier to read).
>> Define also a proper mask (ARM_CPU_PART_MASK) that makes this kind of checks
>> cleaner and helps preventing bugs in the future. Update usage accordingly.
>
> [...]
>
> Tested-by: Kevin Hilman <khilman@xxxxxxxxxx>
>

Great, thanks!

> FWIW, I can confirm that this patch is needed for cpuidle-big_little to
> work on the Exynos5800/Chromebook2.
>

Ok, the patch has been already sent to Russell's patch system.

Best,

- Juri

> Kevin
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/