Re: [PATCH 2/2] tty: serial: uartlite: Remove .owner field for driver

From: Peter Korsgaard
Date: Sat Aug 16 2014 - 18:23:18 EST


>>>>> "Michal" == Michal Simek <michal.simek@xxxxxxxxxx> writes:

> There is no need to init .owner field.
> Based on the patch from Peter Griffin <peter.griffin@xxxxxxxxxx>
> "mmc: remove .owner field for drivers using module_platform_driver"

> This patch removes the superflous .owner field for drivers which
> use the module_platform_driver API, as this is overriden in
> platform_driver_register anyway."

> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>

It would be good with a reference to the commit adding this to
platform_driver_register (9447057eaff8) - But Ok.

Acked-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>

> drivers/tty/serial/uartlite.c | 1 -
> 1 file changed, 1 deletion(-)

> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index 9fc22f40796e..189f52e3111f 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -665,7 +665,6 @@ static struct platform_driver ulite_platform_driver = {
> .probe = ulite_probe,
> .remove = ulite_remove,
> .driver = {
> - .owner = THIS_MODULE,
> .name = "uartlite",
> .of_match_table = of_match_ptr(ulite_of_match),
> },
> --
> 1.8.2.3


--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/