Re: [PATCH 0/2] sched: tasklist_lock cleanups (Was: don't use while_each_thread())

[Oleg Nesterov]

On 08/18, Kirill Tkhai wrote:
>
> On 17.08.2014 19:25, Oleg Nesterov wrote:
> >
> > And I can't understand tg_has_rt_tasks(). Don't we need something
> > like the patch below? If not, please do not ask me why I think so,
> > I don't understand this black magic ;) But the usage of the global
> > "runqueues" array looks suspicious.
>
> This function searches RT task which is related to this tg. It's
> opaquely because it looks that there is an error.
>
> task_rq(p)->rt.tg is a task group of a top rt_rq, while the task may
> be queued on a child rt_rq instead of this. So, your patch is a BUGFIX,
> not a cleanup.

Yes, thanks, this was my (vague) understanding. But since I don't know
even the terminology I wasn't able to explain my concerns.

OK, I am going to shamelessly steal your words and turn them into the
changelog.

Thanks.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/