Re: [PATCH 1/2] gpio: acpi: normalize use of gpiochip_get_desc()

[Alexandre Courbot]

On Tue, Aug 19, 2014 at 2:32 AM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Mon, Aug 18, 2014 at 09:50:56AM -0700, Alexandre Courbot wrote:
>> GPIO descriptors are changing from unique and permanent tokens to
>> allocated resources. Therefore gpiochip_get_desc() cannot be used as a
>> way to obtain a global GPIO descriptor anymore.
>>
>> This patch updates the gpiolib ACPI support code to keep and use the
>> descriptor returned by a centralized call to gpiochip_get_desc().
>>
>> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
>> ---
>>  drivers/gpio/gpiolib-acpi.c | 22 ++++++++++++++--------
>>  1 file changed, 14 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
>> index d62eaaa75397..9596a1023579 100644
>> --- a/drivers/gpio/gpiolib-acpi.c
>> +++ b/drivers/gpio/gpiolib-acpi.c
>> @@ -25,10 +25,12 @@ struct acpi_gpio_event {
>>       acpi_handle handle;
>>       unsigned int pin;
>>       unsigned int irq;
>> +     gpio_desc *desc;
>
> This needs to be
>         struct gpio_desc *desc;
>
>>  };

Oops apologies for this, I should have least have compiled a tree with
this patch on... >_<;

>
> Tested on Asus T100TA and nothing seems to break, so:
>
> Tested-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Thanks! Will send a v2 for Linus to merge, if he agrees with these two patches.
Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/