Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

[Lee Jones]

On Mon, 18 Aug 2014, Brian Norris wrote:

> On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote:
> > On Thu, 14 Aug 2014, Brian Norris wrote:
> > > Particularly, take a hard look at rewriting
> > > include/linux/mtd/stm_nand_bbt.h.
> > 
> > I don't think there is any need - although this change is required:
> > 
> > -#if defined(MTD_NAND_STM_BBT)
> > +#if defined(MTD_NAND_STM_BCH_BBT)
> 
> You're still missing a GPL header and #include guards.
> 
> Your whole patch series (both v1 and v2) also has a few legit
> checkpatch.pl warnings. Please fix these.

Will fix all of the above.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/