Re: [PATCH v2 0/8] mtd: nand: Support for new DT NAND driver

[Lee Jones]

On Mon, 18 Aug 2014, Brian Norris wrote:
> On Mon, Aug 18, 2014 at 11:31:51AM +0100, Lee Jones wrote:
> > I believe all of your queries have either been answered or addressed
> > and I am hoping this will be the last submission. :)
> 
> Sorry, no. I can't review code that doesn't compile, so I'm only now
> getting to some of the review.
> 
> > This is v2 of the squashed submission.  v1 had a small typo which
> > prevented the BBT code from being truly configurable.  This has now
> > been rectified and build tested with and without MTD_NAND_STM_BCH_BBT
> > support.
> 
> From smatch:
> 
>   drivers/mtd/nand/stm_nand_bch.c:1556 stm_nand_bch_probe() error:
>   we previously assumed 'bank' could be null (see line 1482)
>   [smatch] 

I have now built and installed smatch - it is now part of my built
scripts.

> From GCC (extra warnings):
> 
>   drivers/mtd/nand/stm_nand_dt.c:39:21: warning: no previous
>   prototype for 'stm_of_get_partitions_node' [-Wmissing-prototypes] 
>   drivers/mtd/nand/stm_nand_dt.c:68:5: warning: no previous
>   prototype for 'stm_of_get_nand_banks' [-Wmissing-prototypes] 

My build scripts now support extended warnings to level 1.  This was a
pain to get working, as my scripts also build DTBS, which has a side
effect of re-compiling everything, every time.  This was fixed by also
issuing W=1 on the `make $(make_options) $(extra_build_options) dtbs`
line.

> Looks like you forgot to include <linux/mtd/stm_nand_bbt.h>.

This had me confused for a little while.  I think you mean:

  #include "stm_nand_dt.h".

Basically, the DT code wasn't including its own header file.

Caught and fixed.

> And your code is not bisectable. I think patch 7 and 8 should be
> reordered (with some tweaks, perhaps):

Now fixed.

I have split out the BBT header file and applied it first.

> Bisectability test results for configuration
> "arm-multi_v7_defconfig,arm,arm-unknown-linux-gnueabi-" 
> 
> Failed to build patch #7: 5936df30f5e1 mtd: nand: stm_nand_bch: add
> support for ST's BCH NAND controller 
> Configuration: "arm-multi_v7_defconfig, architecture arm".

How do _you_ test for bisectability?  Do you have a script?

What outputs "Failed to build patch #7: ..."?

[...]

> drivers/mtd/nand/stm_nand_bch.c:26:36: fatal error:
> linux/mtd/stm_nand_bbt.h: No such file or directory 
> compilation terminated.
> make[4]: *** [drivers/mtd/nand/stm_nand_bch.o] Error 1

Fixed.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/