Re: [PATCH] booke_wdt: Fix build failure as a module

From: Pranith Kumar
Date: Wed Aug 20 2014 - 09:29:46 EST


On Wed, Aug 20, 2014 at 9:25 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> On Tue, Aug 19, 2014 at 11:12:07PM -0400, Pranith Kumar wrote:
>> Building booke_wdt fails when trying to build as a module as there is no
>> early_param() in module. Fix by enclosing within MODULE check.
>>
> Might make more sense to replace the early_param with a normal module parameter.
> Taking the module parameter away if the driver is built as module seems to be
> a bit excessive.
>
> Any idea why early_param was chosen over a standard module parameter ?


I didn't really investigate. This showed up in a randconfig build
error. I will try to convert this to module param. Thanks!

--
Pranith
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/