Re: [PATCH] regulator: core: Fix build error due to const qualifier for ops

From: Mark Brown
Date: Wed Aug 20 2014 - 11:18:53 EST


On Wed, Aug 20, 2014 at 10:51:33AM +0800, Axel Lin wrote:

> As I mentioned in the commit log:
> Drop const qualifier for ops of struct regulator_desc.
> Allow regulator drivers to update ops before registering regulator.
> So I don't think it's necessary to add const for ops in struct
> regulator_desc.
> (I think the original point was the "regulator core" won't modify the ops).

> The fix is either drop the 'const' qualifier in hi6421-regulator driver or
> add back const qualifier for ops of struct regulator_desc in
> include/linux/regulator/driver.h.
> Which one do you prefer?

Adding back the const qualifier.

Attachment: signature.asc
Description: Digital signature