Re: [RFC] usb: gadget: serial: remove PREFIX macro

From: Sergei Shtylyov
Date: Wed Aug 20 2014 - 12:39:18 EST


Hello.

On 08/20/2014 07:54 PM, Felipe Balbi wrote:

Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with
the hardcoded ttyGS string.

This macro was mostly used in a few debug/warning messages and a lot of
hardcoded ttyGS existed beneath. It may have been used for renaming the
tty, but if done so most debug messages would have ignored this because
of the hardcoded strings.

Due to the fact the usage of this PREFIX instead of the hardcoded strings
in all debug calls would have resulted in a hard to read/grep code it
is removed completely.

Signed-off-by: Richard Leitner <richard.leitner@xxxxxxxxxxx>

patch looks fine, can you resend with RFC in the subject ?

s/with/without/?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/