Re: [PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install

From: Rusty Russell
Date: Wed Aug 20 2014 - 15:47:38 EST


Jim Davis <jim.epost@xxxxxxxxx> writes:
> On Tue, Aug 19, 2014 at 11:57 AM, Bertrand Jacquin <beber@xxxxxxxxxxxx> wrote:
>> Note: shouldn't we use 'install -D $(2)/$@ $@' instead of mkdir
>> and cp ?
>
> Will an install with -D in that sense always be available? That's not
> a flag in the original (BSD) program, and I did find one SPARC system
> -- admittedly an ancient one -- where the install program had a -D
> option but it did something else. install isn't listed as a required
> program in Documentation/Changes, for that matter.

Yes, we don't count on install. And ISTR that install -D would try to
change perms on directories in the path, which can fail if you don't own
them and aren't root...

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/