Re: [PATCH] firmware: Automatically pull missing FW files

[Tadeusz Struk]

On 08/20/2014 01:39 PM, David Woodhouse wrote:
> On Wed, 2014-08-20 at 12:21 -0700, Tadeusz Struk wrote:
>> Hi David,
>> On 08/20/2014 11:34 AM, David Woodhouse wrote:
>>> I'm not sure I understand. Precisely what fails?
>>
>> I clone a subsystem, configure it to use
>> CONFIG_EXTRA_FIRMWARE="qat_895xcc.bin", type make && make install and get:
>>
>> MK_FW   firmware/qat_895xxc.bin.gen.S
>> make[1]: *** No rule to make target `firmware/qat_895xxc.bin', needed by
>> `firmware/qat_895xxc.bin.gen.o'.  Stop.
> 
> Can't you already just use CONFIG_EXTRA_FIRMWARE_DIR ? 


What for? The point is that you don't have the FW binary file and you
have to download it, which can happen automatically and this is what
this patch does. The director where it will be stored doesn't really
matter here.

> 
>> Yes, if you use udev helper. When you want to compile in the blobs to
>> your kernel it is needed in build time, right?
> 
> Yes. But seriously: don't do that. Let firmware get loaded from
> userspace the normal way. Don't build kernel images that you can't distribute
> because they include non-GPL parts.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/