Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C

[Chanwoo Choi]

Hi Geert

Thanks for your report. I already sent a patch[1] to fix this build break
and I'll send pull request to includec this patch in 3.17-rc2.

[1] https://lkml.org/lkml/2014/8/13/761

Best Regards,
Chanwoo Choi


On 08/17/2014 07:08 PM, Geert Uytterhoeven wrote:
> EXTCON_SM5502 selects REGMAP_I2C, but if I2C=n:
> 
> drivers/base/regmap/regmap-i2c.c: In function âregmap_smbus_byte_reg_readâ:
> drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of function âi2c_smbus_read_byte_dataâ
> drivers/base/regmap/regmap-i2c.c: In function âregmap_smbus_byte_reg_writeâ:
> drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of function âi2c_smbus_write_byte_dataâ
> drivers/base/regmap/regmap-i2c.c: In function âregmap_smbus_word_reg_readâ:
> drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of function âi2c_smbus_read_word_dataâ
> drivers/base/regmap/regmap-i2c.c: In function âregmap_smbus_word_reg_writeâ:
> drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of function âi2c_smbus_write_word_dataâ
> drivers/base/regmap/regmap-i2c.c: In function âregmap_i2c_writeâ:
> drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of function âi2c_master_sendâ
> drivers/base/regmap/regmap-i2c.c: In function âregmap_i2c_gather_writeâ:
> drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of function âi2c_check_functionalityâ
> drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of function âi2c_transferâ
> 
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
>  drivers/extcon/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 6f2f4727de2c..764f3a113e0a 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -72,6 +72,7 @@ config EXTCON_PALMAS
>  
>  config EXTCON_SM5502
>  	tristate "SM5502 EXTCON support"
> +	depends on I2C
>  	select IRQ_DOMAIN
>  	select REGMAP_I2C
>  	select REGMAP_IRQ
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/