Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

[Fabio Estevam]

Hi Mark,

On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon <mark.einon@xxxxxxxxx> wrote:

>
> Hi Fabio, thanks for the review.
>
> It's a space alignment of parameters to go with the previous change, to
> keep wrapping consistent in the file:
>
> -       while (i2c_wack) {
> +       while (1) {
>                 if (pci_write_config_byte(pdev, LBCIF_CONTROL_REGISTER,
> -                       LBCIF_CONTROL_LBCIF_ENABLE))
> +                                         LBCIF_CONTROL_LBCIF_ENABLE))
>
> So what are you saying - are you just commenting, document it, put it
> in a seperate patch?

Yes, it would be better if this part was part of a separate patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/