Re: [PATCH v4 1/2] watchdog: Add Cadence WDT driver

[Guenter Roeck]

On Thu, Aug 21, 2014 at 11:57:22AM -0700, Guenter Roeck wrote:
> On Thu, Jul 31, 2014 at 12:10:54PM +0530, Harini Katakam wrote:
> > Add Cadence WDT driver. This is used by Xilinx Zynq.
> > 
> > Signed-off-by: Harini Katakam <harinik@xxxxxxxxxx>
> 
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Hah, that was too fast. The driver causes build errors for a number or
architectures, including x86_64.

drivers/watchdog/cadence_wdt.c: In function 'cdns_wdt_writereg':
drivers/watchdog/cadence_wdt.c:93:2: error: implicit declaration of function
'writel_relaxed' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[2]: *** [drivers/watchdog/cadence_wdt.o] Error 1
make[1]: *** [drivers/watchdog] Error 2

Please make sure that the driver is only configurable for architectures
supporting writel_relaxed.

Thanks,,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/