Re: [PATCH net-next 0/4] r8152: firmware support

From: David Miller
Date: Fri Aug 22 2014 - 22:41:33 EST


From: Hayes Wang <hayeswang@xxxxxxxxxxx>
Date: Wed, 20 Aug 2014 16:58:35 +0800

> Parsing, checking, and writing the firmware.

You haven't told us why you need to do this.

These are just programming registers in the chip, and I see no reason
to not keep these in the driver with real code.

I'm not applying this series, you haven't explained what is happening
here and the reason for doing so. Ironically, that's exactly what you
are supposed to provide in this 0/4 header email.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/