Re: [PATCH] KVM: x86: fix xen guest panic due to lack of KVM_REQ_EVENT

From: Wanpeng Li
Date: Mon Aug 25 2014 - 05:06:47 EST


Hi Paolo,
On Mon, Aug 25, 2014 at 11:01:07AM +0200, Paolo Bonzini wrote:
>Il 25/08/2014 09:58, Wanpeng Li ha scritto:
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index c10408e..b7c0073 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -4928,6 +4928,8 @@ static void toggle_interruptibility(struct kvm_vcpu *vcpu, u32 mask)
>> if (!mask)
>> kvm_make_request(KVM_REQ_EVENT, vcpu);
>> }
>> + if (!(int_shadow || mask))
>> + kvm_make_request(KVM_REQ_EVENT, vcpu);
>> }
>>
>> static void inject_emulated_exception(struct kvm_vcpu *vcpu)
>
>No, this patch undoes the optimization in the buggy patch.
>
>A KVM_REQ_EVENT must be missing somewhere else.
>

Could you give some tips in order that I can figure it out?

Regards,
Wanpeng Li

>Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/