Re: [PATCH v3 6/6] ARM: dts: qcom: Add APQ8074 Dragonboard PMIC GPIO bindings

[Ivan T. Ivanov]

On Wed, 2014-08-20 at 16:06 -0700, Bjorn Andersson wrote:
> On Mon 11 Aug 08:40 PDT 2014, Ivan T. Ivanov wrote:
> > diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard-pmics-pins.dtsi b/arch/arm/boot/dts/qcom-apq8074-dragonboard-pmics-pins.dtsi
> [...]
> > +
> > +&pm8941_gpios {
> > +
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pm8941_gpios_default>;
> > +
> > +	pm8941_gpios_default: default {
> > +		group-1 {
> > +			pins = "gpio1", "gpio2", "gpio5", "gpio29";
> > +			function = PMIC_GPIO_FUNC_NORMAL;
> 
> This looks really strange, I can't get myself to stop thinking that you forgot
> the <> around this (I know it's a string). I don't like these defines.

Same here, any suggestions? Except function tables in driver :-)

> 
> > +			input-enable;
> > +			power-source = <PM8941_GPIO_S3>;
> > +			qcom,pull-up-strength = <PMIC_GPIO_PULL_UP_30>;
> > +		};
> > +		group-6 {	/* TUSB3_HUB-RESET */
> 
> Why not name the nodes something useful?
> If you name it tusb3-hub-reset you can skip the comment.

Sure.
 
> Regards,
> Bjorn

Thanks, 
Ivan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/