Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs

From: Samuel Thibault
Date: Mon Aug 25 2014 - 19:35:02 EST


Hugh Dickins, le Mon 25 Aug 2014 15:00:44 -0700, a écrit :
> On Mon, 25 Aug 2014, Samuel Thibault wrote:
> > Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit :
> > > We could indeed have a loop if the user was making the VT::* leds use
> > > the vt-* trigger,
> >
> > Actually, while there can be a loop, it wouldn't be possible to inject
> > events in it: a VT::* led only makes the corresponding vt-* trigger if
> > it got an event from its trigger, etc. So it's really a false positive,
> > the lock detector just can not know that it can not happen.
>
> I'm not suffering from this lockdep warning myself; but, false positive
> or not, it does need to be fixed (or annotated). Because once lockdep
> reports one issue, it turns itself off. So any developer who hits this
> warning is then unable test their own changes with lockdep afterwards.

Ew. I'll have a look.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/