Re: [PATCH v6 4/4] net: moxa: continue loop on skb allocation failure

From: David Miller
Date: Mon Aug 25 2014 - 20:26:23 EST


From: Jonas Jensen <jonas.jensen@xxxxxxxxx>
Date: Mon, 25 Aug 2014 16:22:40 +0200

> If netdev_alloc_skb_ip_align() fails, subsequent code will
> try to dereference an invalid pointer.
>
> Continue to next descriptor on error.
>
> While we're at it,
>
> 1. eliminate the chance of an endless loop, replace the main
> loop with while(rx < budget)
>
> 2. use napi_complete() and remove the explicit napi_gro_flush()
>
> Signed-off-by: Jonas Jensen <jonas.jensen@xxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/