Re: [PATCH] DRBG: fix bit shifting on 32 bit systems
From: Stephan Mueller
Date: Tue Aug 26 2014 - 03:37:25 EST
Am Dienstag, 26. August 2014, 15:32:19 schrieb Herbert Xu:
Hi Herbert,
> On Tue, Aug 26, 2014 at 09:31:02AM +0200, Stephan Mueller wrote:
> > Use ULL to mark a 64 bit value.
> >
> > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> > Signed-off-by: Stephan Mueller <smueller@xxxxxxxxxx>
>
> I don't think this works as size_t is still 32-bit which means
> that you'll return zero.
Oops, yes. Thank you for catching this. I guess I need __u64 for this value. A
patch will come shortly.
>
> Cheers,
--
Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/