Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga

[Giuseppe CAVALLARO]

On 8/26/2014 9:47 AM, Ley Foon Tan wrote:
> On Tue, Aug 26, 2014 at 3:24 PM, Giuseppe CAVALLARO
> <peppe.cavallaro@xxxxxx> wrote:
> > > @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct
> > > socfpga_dwmac *dwmac, struct device *
> > >                          return -EINVAL;
> > >                  }
> > >
> > > -               dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
> > > +               dwmac->splitter_base =
> > > +                       (void __iomem *)devm_ioremap_resource(dev,
> >
> >
> > I think, no casting should be done:
> >
> >     dwmac->splitter_base = devm_ioremap_resource(dev, ....
> Oh ya, since both are same type. Will send new patch.

thx a lot

> > patch should be for net-next
> Do you mean the patch need based on net-next git?

yes I do.

> I'm using linux-next git now.

ok, can you signal it in the subject (e.g.  [PATCH (net-next)]
This can help on reviewing and IIRC required by Maintainer too

> Thanks.

welcome

BR
peppe

> Regards
> Ley Foon

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/