Re: [PATCH][input-led] Defer input led work to workqueue

From: Samuel Thibault
Date: Tue Aug 26 2014 - 05:13:15 EST


Johannes Berg, le Tue 26 Aug 2014 10:01:35 +0200, a écrit :
> On Tue, 2014-08-26 at 03:54 +0200, Samuel Thibault wrote:
>
> > + vt_led_wq = alloc_workqueue("input_leds", WQ_UNBOUND, 0);
> > + if (!vt_led_wq)
> > + return -ENOMEM;
>
> Does this really need a separate workqueue rather than just using
> schedule_work()? There doesn't seem to be much point in having its own
> workqueue really, to me.

Ah, yes, probably. I'm not up to date with this kind of thing (last
time I used those, they were called tasklets and bottom halves, you
know... ;) ), so I just followed Documentation/workqueue.txt, which does
not talk about schedule_work.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/