Re: [PATCH] perf tools: Allow to specify lib compile variable for spec usage

[Kyle McMartin]

On Mon, Aug 25, 2014 at 10:55 AM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> We need a way to specify $(lib) part of the installation
> path for traceevent plugin libraries. Currently we use
> 'lib64' for x86_64 and 'lib' otherwise.
>
> Instead of listing all possible values, this change allows
> the rpm spec code to specify the correct $(lib) part based
> on processed architecture, like
>
>   $ make ... lib=%{_lib}
>
> Cc: Kyle McMartin <kyle@xxxxxxxxxxx>

I had made a similar change to Fedora, which I replaced with this, and
it worked fine.
LGTM :)

Tested-by: Kyle McMartin <kyle@xxxxxxxxxxx>

> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Corey Ashford <cjashfor@xxxxxxxxxxxxxxxxxx>
> Cc: David Ahern <dsahern@xxxxxxxxx>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> ---
>  tools/perf/config/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 75d4c237b03d..eaf36dafb482 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -651,11 +651,13 @@ else
>  sysconfdir = $(prefix)/etc
>  ETC_PERFCONFIG = etc/perfconfig
>  endif
> +ifndef lib
>  ifeq ($(IS_X86_64),1)
>  lib = lib64
>  else
>  lib = lib
>  endif
> +endif # lib
>  libdir = $(prefix)/$(lib)
>
>  # Shell quote (do not use $(call) to accommodate ancient setups);
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/