Re: [PATCH] block: fix error handling in sg_io

[Jens Axboe]

On 08/26/2014 08:14 AM, Sabrina Dubroca wrote:
> Before commit 2cada584b200 ("block: cleanup error handling in sg_io"),
> we had ret = 0 before entering the last big if block of sg_io.
> 
> Since 2cada584b200, ret = -EFAULT, which breaks hdparm:
> 
> /dev/sda:
>  setting Advanced Power Management level to 0xc8 (200)
>  HDIO_DRIVE_CMD failed: Bad address
>  APM_level      = 128
> 
> Signed-off-by: Sabrina Dubroca <sd@xxxxxxxxxxxxxxx>
> Fixes: 2cada584b200 ("block: cleanup error handling in sg_io")

Thanks, good catch. Someone else reported a regression with identical
symptoms to me yesterday, but did not follow up, so I'm glad you both
found and fixed it.


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/