Re: [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf

[Thomas Gleixner]

On Tue, 26 Aug 2014, Andi Kleen wrote:

> > So what's the point of making the obvious onliner patch
> > 
> > -	case 71:
> > 
> > into something which reorders the sorted case numbers?
>  
> This was a merging mistake. I'll fix it to be a one liner.
> 
> > And of course, this patch is missing any explanation WHY 71 is
> > incorrect and how it got there in the first place.
> 
> 71 is a Broadwell, as you would know if you had read the next patch.

And why on earth do I need to read the next patch to figure out what
the heck this patch is doing?

Just because it's written by someone who gives a shit?

Your unwillingness to cooperate and your advisory resistance are
slowly approaching the Krause level...

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/