RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

[Li.Xiubo@xxxxxxxxxxxxx]

> Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of
> 'big-endian-data'.
> 
> On Tue, Aug 26, 2014 at 7:12 PM, Li.Xiubo@xxxxxxxxxxxxx
> <Li.Xiubo@xxxxxxxxxxxxx> wrote:
> > > > This property used for configuring whether the LSB or the MSB is
> transmitted
> > > > first for the fifo data.
> > >
> > > I don't follow the rationale for this change.
> > >
> > > This looks like a pointless renaming.
> > >
> > > Why is this any better?
> > >
> >
> > This is originally to indicate whether the LSB firstly or MSB firstly will
> be
> > transmitted to the CODEC or received from the CODEC, and there has nothing
> > Relation to the memory data.
> >
> > Generally, if the audio data in big endian format, which will be using the
> bytes
> > Reversion ? Here this can only be used to bits reversion.
> 
> That's why I suggested previously: mention it in the commit comment.
> 
> People will have no idea about what's the exact reason for this change.
> Any functional enhancement? Or a bug fix(more likely for this one).
> I'm not sure what I described in the previous mail is correct or not.
> But you probably should have added it into the commit comments.
> 
> And Xiubo, this patch still hasn't fixed the issue of breaking the old DT,
> although system can pass during the probe() section.
> 

Beside LS1+, who else is using this now ? And the LS1 dts files are still doing
The upstream for now.

Thanks,

BRs
Xiubo


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/