Re: [PATCH v3 5/5] [S390] zcrypt: use seq_hex_dump() to dump buffers

[Ingo Tuchscherer]

I have verified and tested the patch for the zcrypt part.
OK from my side. You can add my Acked-by.
Acked-by: Ingo Tuchscherer <ingo.tuchscherer@xxxxxxxxxx>

Thanks

Mit freundlichen Grüßen / Kind regards

Ingo Tuchscherer

Software Development - Linux on System z
IBM Systems &Technology Group
                                                                       
                                                                       
                                                                       
                                                                       
                                                                       
 Phone:            +49-7031-16-1986                 IBM Deutschland                          (Embedded
                                                                                           image moved
                                                                                              to file:
                                                                                         pic53004.gif)
                                                                       
 E-Mail:           ingo.tuchscherer@xxxxxxxxxx      Schoenaicher Str. 220
                                                                       
                                                    71032 Boeblingen   
                                                                       
                                                    Germany            
                                                                       
                                                                       
                                                                       
                                                                       
                                                                       
 IBM Deutschland                                                       
 Research &                                                            
 Development                                                           
 GmbH /                                                                
 Vorsitzender des                                                      
 Aufsichtsrats:                                                        
 Martina Koederitz                                                     
                                                                       
 Geschäftsführung:                                                 
 Dirk Wittkopp                                                         
 Sitz der                                                              
 Gesellschaft:                                                         
 Böblingen /                                                         
 Registergericht:                                                      
 Amtsgericht                                                           
 Stuttgart, HRB                                                        
 243294                                                                
                                                                       





From:	Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
To:	Tadeusz Struk <tadeusz.struk@xxxxxxxxx>, Herbert Xu
            <herbert@xxxxxxxxxxxxxxxxxxx>, Mauro Carvalho Chehab
            <m.chehab@xxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Ingo
            Tuchscherer/Germany/IBM@IBMDE, Alexander Viro
            <viro@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Joe
            Perches <joe@xxxxxxxxxxx>, Marek Vasut <marex@xxxxxxx>,
Cc:	Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date:	08/25/2014 11:03 AM
Subject:	[PATCH v3 5/5] [S390] zcrypt: use seq_hex_dump() to dump
            buffers



Instead of custom approach let's use recently introduced seq_hex_dump()
helper.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
 drivers/s390/crypto/zcrypt_api.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/s390/crypto/zcrypt_api.c
b/drivers/s390/crypto/zcrypt_api.c
index 0e18c5d..d1f9983 100644
--- a/drivers/s390/crypto/zcrypt_api.c
+++ b/drivers/s390/crypto/zcrypt_api.c
@@ -1203,16 +1203,8 @@ static void sprinthx(unsigned char *title, struct
seq_file *m,
 static void sprinthx4(unsigned char *title, struct seq_file *m,
 		 		       unsigned int *array, unsigned int len)
 {
-		 int r;
-
 		 seq_printf(m, "\n%s\n", title);
-		 for (r = 0; r < len; r++) {
-		 		 if ((r % 8) == 0)
-		 		 		 seq_printf(m, "    ");
-		 		 seq_printf(m, "%08X ", array[r]);
-		 		 if ((r % 8) == 7)
-		 		 		 seq_putc(m, '\n');
-		 }
+		 seq_hex_dump(m, "    ", DUMP_PREFIX_NONE, 32, 4, array, len,
false);
 		 seq_putc(m, '\n');
 }

--
2.1.0

Attachment: pic53004.gif
Description: GIF image