Re: [PATCH] regmap: Don't attempt block writes when syncing cache on single_rw devices

From: Jarkko Nikula
Date: Wed Aug 27 2014 - 09:30:56 EST


On 08/27/2014 03:09 PM, Mark Brown wrote:
From: Mark Brown <broonie@xxxxxxxxxx>

If the device can't support block writes then don't attempt to use raw
syncing which will automatically generate block writes for adjacent
registers, use the existing _single() block syncing implementation.

Reported-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
---
drivers/base/regmap/regcache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

This works too with RT5642. It appeared page select for _regmap_write() is actually handled implicitly for certain cases. regmap_init() sets "map->reg_write = _regmap_bus_raw_write" in this case and _regmap_bus_raw_write() then calls _regmap_raw_write(). I guess that can be fixed when doing other cleanups or if some setup hits it.

Tested-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/