Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups

[Pranith Kumar]

On Wed, Aug 27, 2014 at 12:21 PM, Paul E. McKenney
<paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Aug 27, 2014 at 10:13:50AM +0530, Amit Shah wrote:

>>
>> Yes, this patch helps my case as well.
>
> Very good!!!
>
> Pranith, I can take this patch, but would you be willing to invert
> the sense of ->nocb_leader_wake (e.g., call it ->nocb_leader_sleep or
> some such)?  This field is only used in eight places in the source code.
>
> The idea is that inverting the sense of the field allows the normal C
> initialization of zero to properly initialize this field, plus it gets
> rid of a few lines of code.
>

Sure, that is indeed a good idea. I will send a new patch.

-- 
Pranith
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/