Re: [PATCH 1/1] regulator: max77802: set opmode to normal if off is read from hw

[Tomasz Figa]

On 27.08.2014 21:44, Mark Brown wrote:
> On Wed, Aug 27, 2014 at 09:21:02PM +0200, Tomasz Figa wrote:
>> On 27.08.2014 21:15, Mark Brown wrote:
> 
>>> This is in the scenario where the previously running Linux changed the
>>> mode to something other than normal and where the freshly booted Linux
>>> can't figure out how to do that when it needs to.  I'm not sure how
>>> plausible that scenario is, or that real systems would handle it
>>> robustly.
> 
>> I'm not sure I'm getting your point.
> 
>> If the only thing Linux can do is read back the opmode from PMIC
>> registers, it doesn't explicitly set it to something other, but rather
>> reuses what was set by something before it (or, after this patch,
>> defaults to NORMAL if it's OFF), i.e. the low level firmware or Linux.
> 
>> However the information about original setting is lost whenever Linux
>> turns the regulator off and performs a warm reboot, which I believe
>> would be a quite common scenario.
> 
> The point is that if anything was setting the mode to something other
> than normal it was almost certainly a previously running copy of Linux
> and one would expect that if the mode does need to be changed the new
> copy will be doing that anyway.  It's rare enough to need to actively
> manage modes in the first place.
> 

>From what I know based on my experience with Samsung boards we used, the
opmodes of regulators are preconfigured by board bootloader to certain
values based on power design of the board (i.e. there is no need to keep
a regulator in full power mode, if on given board only a little fraction
of it is needed).

Now Linux should not change this mode (excluding cases when the values
in the bootloader are wrong - they happen unfortunately), so I'm not
getting why you say that it is Linux which changes the mode to something
other than normal. Linux should only toggle between the value resulting
from power design and off.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/