Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

[Doug Anderson]

Dmitry,

On Wed, Aug 27, 2014 at 10:21 AM, Dmitry Torokhov <dtor@xxxxxxxxxxxx> wrote:
> On Wednesday, August 27, 2014 02:39:36 PM Lee Jones wrote:
>> On Tue, 26 Aug 2014, Chris Zhong wrote:
>> > +
>> > +static struct of_device_id rk808_of_match[] = {
>> > +   { .compatible = "rockchip,rk808" },
>> > +};
>> > +MODULE_DEVICE_TABLE(of, rk808_of_match);
>> > +
>> > +static const struct i2c_device_id rk808_ids[] = {
>> > +    { "rk808" },
>> > +};
>> > +
>> > +MODULE_DEVICE_TABLE(i2c, rk808_ids);
>>
>> My OCD senses are tingling.  Either have a blank line above the calls
>> to MODULE_DEVICE_TABLE() or don't.
>
> Wait, don't we also need sentinel entries in both these tables?

Yes!  Good catch.  Last I reviewed the code it was there...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/